p-token: Add custom entrypoint #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
force-pushed
the
febo/custom-entrypoint
branch
from
3d74a84 to
fafdd3e
Compare
febo
force-pushed
the
febo/simplify-math
branch
from
2edf20b to
9e62a06
Compare
febo
force-pushed
the
febo/custom-entrypoint
branch
from
fafdd3e to
8a3de38
Compare
joncinque
approved these changes
Sep 2, 2025
Comment on lines
+110
to
+115
| && (*input.add(ACCOUNT1_DATA_LEN).cast::<u64>() == 165) | ||
| && (*input.add(ACCOUNT2_HEADER_OFFSET) == 255) | ||
| && (*input.add(ACCOUNT2_DATA_LEN).cast::<u64>() == 82) | ||
| && (*input.add(IX12_ACCOUNT3_HEADER_OFFSET) == 255) | ||
| && (*input.add(IX12_ACCOUNT3_DATA_LEN).cast::<u64>() == 165) | ||
| && (*input.add(IX12_ACCOUNT4_HEADER_OFFSET) == 255) |
There was a problem hiding this comment.
nit: let's use the consts for token account size / mint size / non-dup marker here
Comment on lines
+75
to
+76
|
|
||
| /// Offset for the second account. |
There was a problem hiding this comment.
Suggested change
| /// Offset for the second account. | |
| /// Offset for the third account. |
Comment on lines
+62
to
+66
| /// Offset for the fourth account data length. | ||
| /// | ||
| /// This is expected to be an account with variable data | ||
| /// length. | ||
| const IX12_ACCOUNT4_DATA_LEN: usize = 0x7b20; |
There was a problem hiding this comment.
This is only ever used once, and still called with align -- why not just put the aligned value as the const?
| // Check that we have enough instruction data. | ||
| // | ||
| // Expected: instruction discriminator (u8) + amount (u64) + decimals (u8) | ||
| if input.add(offset).cast::<usize>().read() >= 10 { |
There was a problem hiding this comment.
nit: maybe use u64 here since size_of::<u64>() is added right after?
Suggested change
| if input.add(offset).cast::<usize>().read() >= 10 { | |
| if input.add(offset).cast::<u64>().read() >= 10 { |
| let discriminator = input.add(offset + size_of::<u64>()).cast::<u8>().read(); | ||
|
|
||
| // Check for transfer discriminator. | ||
| if likely(discriminator == 12) { |
There was a problem hiding this comment.
nit: can you use const here too?
Comment on lines
+83
to
+85
| /// Offset for the third account data length. This is | ||
| /// expected to be a mint account (82 bytes). | ||
| const IX3_ACCOUNT3_DATA_LEN: usize = 0x5268; |
There was a problem hiding this comment.
Same with this, just align it from the start?
Comment on lines
+68
to
+69
| /// Expected offset for the instruction data in the case all | ||
| /// previous accounts have zero data. |
There was a problem hiding this comment.
Shouldn't this only assume that the authority has zero data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently
p-tokenuses the "generic" entrypoint. There is an opportunity to give priority to most used instruction to further save CUs. Looking at token instructions from a period of one month, the most used instructions are:transfer_checked36.33%transfer13.22%close_account12.23%initialize_account39.98%initialize_immutable_owner9.78%sync_native4.53%initialize_account2.58%Other instructions account for less than
1%each.Solution
This PR adds a custom entrypoint to
p-tokenthat includes a "fast-path" to transfer instructions. It also modifies the current processor to give priority tosync_nativeandinitialize_immutable_ownerinstructions. Both modifications lead to significant improvements in CU consumption when considering the usage distribution.➡️ Credits to @cavemanloverboy for the "fast-path" approach.