You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the PR. So there's two reasons I suggested changing how get_channel_access is called. The first is that it's a step on the way to allowing override to work on channels you're not in in general, which might be a useful feature. But the one that's more directly relevant to this PR relates to module interaction. I think override should be aiming to report only if (a) the action was only allowed because of override, and (b) the action is going to go ahead. Using CHFL_OVERRIDE, while a bit of a hack, enables that quite nicely, since a high-priority hook (and honestly most of override should probably be using MONITOR rather than HIGHEST) can tell whether override was used (based on the alevel) and if the action is actually going to happen (based on the hook approval). While the rest of override is not doing this yet, that's the direction I think we should be going in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61 - applies suggestions from #117