Open
Conversation
progval
commented
Feb 14, 2026
Comment on lines
+90
to
+100
| - name: Make artifact tarball | ||
| run: |- | ||
| cd ~ | ||
| tar -czf artifacts-solanum.tar.gz ircd/ | ||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v6 | ||
| if: matrix.os == 'ubuntu-24.04' && matrix.compiler == 'gcc-13' | ||
| with: | ||
| name: installed-solanum-${{matrix.os}}-${{matrix.compiler}} | ||
| path: ~/artifacts-solanum.tar.gz | ||
| retention-days: 1 |
Contributor
Author
There was a problem hiding this comment.
I chose to make one of the existing builds (the fastest one) export its artifacts at the end for the irctest job. This minimizes CPU usage, but unnecessarily increases the wall-clock run time because the dependency means the test job waits for every build job to be done.
I can make the test jobs have its their own build concurrently to the other ones if you prefer.
internet-catte
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/inspircd/inspircd/blob/148a90535c1b061efcc13439056f8ab786086084/.github/workflows/ci-irctest.yml
It caught these regressions in the past:
h_privmsg_channelhook without settingmsgbuf#484