Access "response" of CoreAdmin queries#1167
Merged
mkalkbrenner merged 1 commit intosolariumphp:masterfrom Nov 15, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
+ Coverage 98.13% 98.16% +0.02%
==========================================
Files 404 404
Lines 10626 10632 +6
==========================================
+ Hits 10428 10437 +9
+ Misses 198 195 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
65fa254 to
54de07d
Compare
54de07d to
6fcf1e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreAdminqueries can have a field named"response"in the JSON response data. Parsing that data assigned its value (of typearray) toSolarium\Core\Query\Result\Result::$response(of typeSolarium\Core\Client\Response).This caused a
TypeErrorwhen callingResult::getResponse()to get theResponseobject.It also caused an
Errorwhen trying to accessResult::$responseto get the value.This PR fixes both problems by storing it under a different property name but making it accessible under its original name through property overloading.