This repository was archived by the owner on Apr 15, 2026. It is now read-only.
relocate caffeine to a different namespace - #50
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates shaded Caffeine and its transitive dependencies to a more specific namespace within the sampling module to prevent potential classpath conflicts. The version is also bumped to reflect this breaking change.
Key Changes:
- Shaded packages now use
com.solarwinds.joboe.sampling.shaded.*instead ofcom.solarwinds.joboe.shaded.* - Project version incremented from 10.0.26-SNAPSHOT to 10.0.27-SNAPSHOT
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sampling/pom.xml | Updates Maven shade plugin relocations to use module-specific namespace for caffeine, checkerframework, and errorprone |
| pom.xml | Bumps project version to 10.0.27-SNAPSHOT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.