Conversation
|
Thank you for the submission, I'm a bit low on time right now so it might take a bit before I can have a proper look at this, but please know that it is appreciated :) |
|
No worries! I noticed that the workflow failed because of Edit: ok, apparently I was using an outdated docker image (which had an older version of some key components in the compilation process). I've forked the docker image that I used and updated it. After that I was able to reproduce the issue I saw in the workflow on my machine. Then I decided to mimic the approach that I saw somewhere else in this project and introducing a |
76cfcd5 to
f2c43e1
Compare
I implemented backlight dimming and added a few "registers" for configuring it (
REG_ID_BK3andREG_ID_BK4). I wasn't sure how much of the logic you wanted to expose in registers, so I decided to add some variables inbacklight.hinstead of bringing everything to the registers.I'm running the changes on my board and it seems to be working as intended: disabling the timeout disables dimming. And changing the timeout does result in a dimmer backlight. I'm pretty sure the alarm/timing could be improved but I didn't want to fire too many events and risk getting in the way of other tasks.