feat(shapes): all shapes require class and iri#63
Merged
elf-pavlik merged 1 commit intosolid:mainfrom Jul 29, 2025
Merged
Conversation
elf-pavlik
force-pushed
the
class-and-iri
branch
2 times, most recently
from
5ff2860 to
5b6c41d
Compare
elf-pavlik
force-pushed
the
class-and-iri
branch
from
5b6c41d to
273db4c
Compare
jeff-zucker
approved these changes
Jul 29, 2025
Member
Author
|
@jeswr would you like us to wait for your review before merging this PR? |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup for #61
Now all shapes will have
sh:nodeKind sh:IRIto ensure we use IRIs for catalogued resourcessh:classto ensure each resource hasrdf:type, which we also use to target validation (sh:targetClass)I will create a separate issue to find a way to ensure that all resources are validated. Currently if resource doesn't have any
rdf:typeit will not be validated at all (unless I miss something about targeting) #65I think this PR may be enough to close #45
At least for now I'm leaving
IRIon properties that usesh:nodewith shapes which havesh:classconstraint. Even though those constrains are now converted to ShEx, LDO still doesn't use them.