Closed
Conversation
Signed-off-by: Elliot <elliotfriedman3@gmail.com>
Signed-off-by: Elliot <elliotfriedman3@gmail.com>
Signed-off-by: Elliot <elliotfriedman3@gmail.com>
Signed-off-by: Elliot <elliotfriedman3@gmail.com>
Signed-off-by: Elliot <elliotfriedman3@gmail.com>
Contributor
Author
|
Putting this on the back burner for now since it will require a redeployment across all chains. #63 |
ElliotFriedman
commented
Nov 5, 2025
| /// @dev minimum delay for timelocked operations | ||
| // minimum delay for timelocked operations | ||
| // there is no minimum timelock duration enforced when creating a timelock, | ||
| // however it is recommended to set a timelock duration of at least a few hours as an end user |
Contributor
Author
There was a problem hiding this comment.
remove this constant
Contributor
Author
There was a problem hiding this comment.
maybe just move it into a test fixture file instead of leaving in constants
Contributor
Author
|
fix failing integration test: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the enforced lower bound on minimum delay.
This is intentional and we accept all risks that come with this.
https://prover.certora.com/output/651303/65ef282431474a29b9bf49cd58028138?anonymousKey=c9db8981c953b7ab947389a7d0c94d14881146cf