Skip to content

Commit 0d0f44e

Browse files
committed
Added test case for prev value without default.
1 parent b84cc7e commit 0d0f44e

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

docs/no-react-deps.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,15 @@ createEffect(() => {
7171
});
7272

7373
createEffect((prev) => {
74-
console.log(signal() + prev);
74+
console.log(signal());
75+
return prev + 1;
7576
}, 0);
7677

78+
createEffect((prev) => {
79+
console.log(signal());
80+
return (prev || 0) + 1;
81+
});
82+
7783
const value = createMemo(() => computeExpensiveValue(a(), b()));
7884

7985
const sum = createMemo((prev) => input() + prev, 0);

test/rules/no-react-deps.test.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,13 @@ export const cases = run("no-react-deps", rule, {
77
console.log(signal());
88
});`,
99
`createEffect((prev) => {
10-
console.log(signal() + prev);
10+
console.log(signal());
11+
return prev + 1;
1112
}, 0);`,
13+
`createEffect((prev) => {
14+
console.log(signal());
15+
return (prev || 0) + 1;
16+
});`,
1217
`const value = createMemo(() => computeExpensiveValue(a(), b()));`,
1318
`const sum = createMemo((prev) => input() + prev, 0);`,
1419
`const args = [() => { console.log(signal()); }, [signal()]];

0 commit comments

Comments
 (0)