Skip to content

Conversation

@thetarnav
Copy link
Member

@thetarnav thetarnav commented Sep 29, 2024

Rewrites build script to build all packages in one process
Similarly to how testing works
So no turborepo cashing, but it's much faster overall
5s to build all packages instead of a couple of minutes
So should be much easier for new people to fork and build locally and not have to wait so much
Also website deploys could happen on main now as the netlify build should be a lot faster

Proper turbo-like caching could be added later as well and be used for tests too, without sacrificing the time to build all packages.
tsc -b takes care of caching pretty much

Please run rm -rf packages/*/dist/* .turbo packages/*/.turbo to clear old files

This also removes CJS support

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2024

🦋 Changeset detected

Latest commit: dae3b77

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@atk
Copy link
Member

atk commented Sep 29, 2024

Since the removal of CJS support might be considered a breaking change, shouldn't this be a major update? Minor breaking changes are a violation of semver.

Also, in CONTRIBUTING.md, the design maxim number 12 still includes CJS support.

@atk atk self-requested a review January 15, 2025 14:12
@thetarnav
Copy link
Member Author

@atk it's not yet done
I'm experimenting with using tsc -b for building now. Then esbuild will be necessary only for the two packages that use jsx - controlled-props and virtual.

@thetarnav thetarnav marked this pull request as ready for review January 20, 2025 20:50
@thetarnav thetarnav merged commit c1ea940 into main Jan 22, 2025
3 checks passed
@thetarnav thetarnav deleted the new-build branch January 22, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants