-
Notifications
You must be signed in to change notification settings - Fork 146
Rewrite build script to build all packages in one process (Removes CJS) #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: dae3b77 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
52bc9e5 to
30949cc
Compare
|
Since the removal of CJS support might be considered a breaking change, shouldn't this be a major update? Minor breaking changes are a violation of semver. Also, in CONTRIBUTING.md, the design maxim number 12 still includes CJS support. |
|
@atk it's not yet done |
Rewrites build script to build all packages in one process
Similarly to how testing works
So no turborepo cashing, but it's much faster overall
5s to build all packages instead of a couple of minutes
So should be much easier for new people to fork and build locally and not have to wait so much
Also website deploys could happen on main now as the netlify build should be a lot faster
Proper turbo-like caching could be added later as well and be used for tests too, without sacrificing the time to build all packages.tsc -btakes care of caching pretty muchPlease run
rm -rf packages/*/dist/* .turbo packages/*/.turboto clear old filesThis also removes CJS support