fix: selection contenteditable node detection #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4ddea69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
atk
force-pushed
the
fix-contenteditable-node-detection
branch
from
e626353 to
f3ed2d6
Compare
Member
|
Why not change the logic only in the NaN case? tbh they only think that is missing is some sort of acknowledgement of that edge-case in the code |
Member
Author
|
This fix addresses the only cause for the NaN case that I could find, which seems to be inconsistent browser behavior. First checking for NaN and only then checking if the parent matches will only increase the code size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you triple click on an li inside a list inside a contenteditable div (except for the last one), you get a selectionEnd of NaN. This is because for reasons unknown, in this case we receive the parent of the text node instead of the text node in the range.