Skip to content

Conversation

@atk
Copy link
Member

@atk atk commented Apr 20, 2025

fixes #785

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2025

🦋 Changeset detected

Latest commit: 7fbc758

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/range Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thetarnav
Copy link
Member

can i has test case? :)

@webstrand
Copy link
Contributor

You'll also need to clone the array here:

currently it reuses the array when growing, but slices it when shrinking.

I hadn't realized anyone else was working on a fix for this, I did not mean to duplicate work.

@atk
Copy link
Member Author

atk commented Apr 20, 2025

I just tested it - this approach does not work, since we return the initial instance and overwriting it internally will not change the external reference. This needs more thought.

@atk atk closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<Repeat/> does not update when its times.prop changes

4 participants