Skip to content

Fix title not updating on package page #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thetarnav merged 4 commits into from
Jan 10, 2026
+11 −4
Merged

Fix title not updating on package page #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0a3b61
Fix build issues in gqlgen and networks
SnowSquire Jan 10, 2026
3fa3ba9
Update app.tsx imports and use Title component
SnowSquire Jan 10, 2026
f5abdc3
Fix issues in multiple packages and site title
SnowSquire Jan 10, 2026
fe514ce
Remove site from changeset
thetarnav Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/cool-gifts-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@solid-primitives/graphql": patch
"@solid-primitives/share": patch
---

@solid-primitives/graphql: Fix a build issue occurring during the bundling process.
@solid-primitives/share: Fix a typo for Facebook Messenger
2 changes: 1 addition & 1 deletion packages/graphql/dev/gqlgen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as gql_doc from "@graphql-typed-document-node/core";
import type * as gql_doc from "@graphql-typed-document-node/core";
export type Maybe<T> = T | null;
export type InputMaybe<T> = Maybe<T>;
export type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };
Expand Down
2 changes: 1 addition & 1 deletion packages/share/src/networks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const HACKERNEWS: Network = "https://news.ycombinator.com/submitlink?u=@u
export const INSTAPAPER: Network = "http://www.instapaper.com/edit?url=@u&title=@t&description=@d";
export const LINE: Network = "http://line.me/R/msg/text/?@t%0D%0A@u%0D%0A@d";
export const LINKEDIN: Network = "https://www.linkedin.com/sharing/share-offsite/?url=@u";
export const MESSANGER: Network = "fb-messenger://share/?link=@u";
export const MESSENGER: Network = "fb-messenger://share/?link=@u";
/** @deprecated Use MESSENGER instead - this will be removed in a future version */
export const MESSANGER: Network = MESSENGER;
export const ODNOKLASSNIKI: Network =
Expand Down
4 changes: 2 additions & 2 deletions site/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import "./app.scss";
import Header from "./components/Header/Header.js";
import SolidBlocksHeaderClusterDefs from "./components/Icons/SolidBlocksHeaderClusterDefs.js";
import Footer from "./components/Footer/Footer.js";
import { MetaProvider } from "@solidjs/meta";
import { MetaProvider, Title } from "@solidjs/meta";
import { Router } from "@solidjs/router";
import { FileRoutes } from "@solidjs/start/router";
import DocumentHydrationHelper from "./primitives/DocumentHydrationHelper.jsx";
Expand All @@ -31,7 +31,7 @@ function RootContent(props: ParentProps) {
return (
<html lang="en" data-html>
<head>
<title>Solid Primitives</title>
<Title>Solid Primitives</Title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="og:url" content={SITE_URL} />
Expand Down
Loading