Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/chatty-weeks-look.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@solidjs/router": patch
---

- Improve route matching fallback
- Optimize imports
52 changes: 23 additions & 29 deletions src/routers/components.tsx
Original file line number Diff line number Diff line change
@@ -1,36 +1,27 @@
/*@refresh skip*/

import type { Component, JSX, Owner } from "solid-js";
import { type RequestEvent, getRequestEvent, isServer } from "solid-js/web";
import type {Component, JSX, Owner} from "solid-js";
import {children, createMemo, createRoot, getOwner, mergeProps, on, Show, untrack} from "solid-js";
import {getRequestEvent, isServer, type RequestEvent} from "solid-js/web";
import {
children,
createMemo,
createRoot,
getOwner,
mergeProps,
on,
Show,
untrack
} from "solid-js";
import {
createBranches,
createRouteContext,
createRouterContext,
getIntent,
getRouteMatches,
RouteContextObj,
RouterContextObj,
setInPreloadFn
createBranches,
createRouteContext,
createRouterContext,
getIntent,
getRouteMatches,
RouteContextObj,
RouterContextObj,
setInPreloadFn
} from "../routing.js";
import type {
MatchFilters,
RouteContext,
RouteDefinition,
RouterIntegration,
RouterContext,
Branch,
RouteSectionProps,
RoutePreloadFunc
Branch,
MatchFilters,
RouteContext,
RouteDefinition,
RoutePreloadFunc,
RouterContext,
RouterIntegration,
RouteSectionProps
} from "../types.js";

export type BaseRouterProps = {
Expand Down Expand Up @@ -142,7 +133,10 @@ function Routes(props: { routerState: RouterContext; branches: Branch[] }) {
props.routerState,
next[i - 1] || props.routerState.base,
createOutlet(() => routeStates()[i + 1]),
() => props.routerState.matches()[i]
() => {
const routeMatches = props.routerState.matches();
return routeMatches[i] ?? routeMatches[0];
}
);
});
}
Expand Down