Skip to content

Conversation

@atilafassina
Copy link
Member

@atilafassina atilafassina commented Nov 18, 2025

This PR creates a changeset for publishing the @solidjs/vite-plugin-nitro-2 to NPM.

a deploy release can be tested using the instructions below

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

🦋 Changeset detected

Latest commit: c6025f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/vite-plugin-nitro-2 Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit c6025f4
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/69230d0ffb3b40000861476d
😎 Deploy Preview https://deploy-preview-2004--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2004
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2004

commit: c6025f4

@brenelz
Copy link
Contributor

brenelz commented Nov 19, 2025

I know the Nitro team pushing people pretty hard to use v3 but this probably works in the meantime

@atilafassina
Copy link
Member Author

I know the Nitro team pushing people pretty hard to use v3 but this probably works in the meantime

We discussed this the other day and I already talked to the Nitro team about it. We're support Nitro 2 and 3 during alpha and only deprecate Nitro 2 support in the future.

@atilafassina atilafassina force-pushed the plugin/nitro-2 branch 3 times, most recently from 38ebc8c to 09952f6 Compare November 22, 2025 18:46
@atilafassina atilafassina changed the title Nitro 2 as plugin Publish @solidjs/vite-plugin-nitro-2 Nov 22, 2025
@atilafassina atilafassina requested a review from Copilot November 22, 2025 18:59
@atilafassina atilafassina self-assigned this Nov 22, 2025
Copilot finished reviewing on behalf of atilafassina November 22, 2025 19:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the @solidjs/vite-plugin-nitro-2 package for publication to NPM. The package consolidates Nitro v2 integration into a Vite plugin for use with SolidStart 2.0.

Key changes:

  • Renamed package from @solidjs/start-nitro-v2-vite-plugin to @solidjs/vite-plugin-nitro-2
  • Updated package.json with proper exports, files list, and build configuration for NPM publishing
  • Added TypeScript configuration changes (module/moduleResolution from "ESNext"/"bundler" to "NodeNext"/"NodeNext") for better Node.js compatibility
  • Added README documentation with usage examples
  • Reformatted source code (whitespace/indentation changes only)
  • Added new CI workflow for type checking distributed packages
  • Updated continuous release workflow to publish all packages

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/start-nitro-v2-vite-plugin/package.json Updated package name, added description, configured exports for distribution, added build scripts and peer dependencies
packages/start-nitro-v2-vite-plugin/tsconfig.json Changed module resolution from "ESNext"/"bundler" to "NodeNext"/"NodeNext" for better Node.js ESM compatibility
packages/start-nitro-v2-vite-plugin/src/index.ts Reformatted code (whitespace/indentation only, no logic changes)
packages/start-nitro-v2-vite-plugin/README.md Added documentation with usage examples and prerendering configuration
.changeset/honest-needles-grow.md Added changeset for minor version bump
.github/workflows/dist-typecheck.yml Added new workflow to type check distributed packages
.github/workflows/cr.yml Updated to publish all packages instead of just @solidjs/start
pnpm-lock.yaml Updated with new dependencies (tsdown, rolldown, and related packages)
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

atilafassina and others added 2 commits November 23, 2025 09:46
Co-authored-by: Copilot <[email protected]>
Copilot finished reviewing on behalf of atilafassina November 23, 2025 09:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

const publicDir = nitro.options.output.publicDir;

// As a part of the build process, the `.vite/` directory
// is copied over from `node_modules/.tanstack-start/client-dist/`
Copy link

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions .tanstack-start but this is a SolidStart plugin, not a TanStack Start plugin. This appears to be copied from TanStack Start code. The comment should be updated to reflect the correct path for SolidStart (likely node_modules/.solid-start/... or similar), or removed if it doesn't apply to this context.

Suggested change
// is copied over from `node_modules/.tanstack-start/client-dist/`
// may be copied over from `node_modules/.solid-start/client-dist/`

Copilot uses AI. Check for mistakes.
@huseeiin
Copy link
Contributor

why does this exist since nitro v3 already works fine with solidstart?

@brenelz
Copy link
Contributor

brenelz commented Nov 23, 2025

why does this exist since nitro v3 already works fine with solidstart?

There is still some issues with v3 that are solved using the v2 plugin. So its a temporary thing while the kinks get ironed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants