-
Notifications
You must be signed in to change notification settings - Fork 401
Publish @solidjs/vite-plugin-nitro-2
#2004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c6025f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
dadb0a5 to
8d2f803
Compare
|
I know the Nitro team pushing people pretty hard to use v3 but this probably works in the meantime |
We discussed this the other day and I already talked to the Nitro team about it. We're support Nitro 2 and 3 during alpha and only deprecate Nitro 2 support in the future. |
38ebc8c to
09952f6
Compare
09952f6 to
47d972b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR prepares the @solidjs/vite-plugin-nitro-2 package for publication to NPM. The package consolidates Nitro v2 integration into a Vite plugin for use with SolidStart 2.0.
Key changes:
- Renamed package from
@solidjs/start-nitro-v2-vite-pluginto@solidjs/vite-plugin-nitro-2 - Updated package.json with proper exports, files list, and build configuration for NPM publishing
- Added TypeScript configuration changes (module/moduleResolution from "ESNext"/"bundler" to "NodeNext"/"NodeNext") for better Node.js compatibility
- Added README documentation with usage examples
- Reformatted source code (whitespace/indentation changes only)
- Added new CI workflow for type checking distributed packages
- Updated continuous release workflow to publish all packages
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/start-nitro-v2-vite-plugin/package.json |
Updated package name, added description, configured exports for distribution, added build scripts and peer dependencies |
packages/start-nitro-v2-vite-plugin/tsconfig.json |
Changed module resolution from "ESNext"/"bundler" to "NodeNext"/"NodeNext" for better Node.js ESM compatibility |
packages/start-nitro-v2-vite-plugin/src/index.ts |
Reformatted code (whitespace/indentation only, no logic changes) |
packages/start-nitro-v2-vite-plugin/README.md |
Added documentation with usage examples and prerendering configuration |
.changeset/honest-needles-grow.md |
Added changeset for minor version bump |
.github/workflows/dist-typecheck.yml |
Added new workflow to type check distributed packages |
.github/workflows/cr.yml |
Updated to publish all packages instead of just @solidjs/start |
pnpm-lock.yaml |
Updated with new dependencies (tsdown, rolldown, and related packages) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
47d972b to
03deadc
Compare
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
8cf3247 to
5d721a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const publicDir = nitro.options.output.publicDir; | ||
|
|
||
| // As a part of the build process, the `.vite/` directory | ||
| // is copied over from `node_modules/.tanstack-start/client-dist/` |
Copilot
AI
Nov 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment mentions .tanstack-start but this is a SolidStart plugin, not a TanStack Start plugin. This appears to be copied from TanStack Start code. The comment should be updated to reflect the correct path for SolidStart (likely node_modules/.solid-start/... or similar), or removed if it doesn't apply to this context.
| // is copied over from `node_modules/.tanstack-start/client-dist/` | |
| // may be copied over from `node_modules/.solid-start/client-dist/` |
|
why does this exist since nitro v3 already works fine with solidstart? |
There is still some issues with v3 that are solved using the v2 plugin. So its a temporary thing while the kinks get ironed out |
This PR creates a changeset for publishing the
@solidjs/vite-plugin-nitro-2to NPM.a deploy release can be tested using the instructions below