Skip to content

Conversation

@huseeiin
Copy link
Contributor

use already-existing h3 URL. might boost performance slightly

PR Checklist

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

use already-existing h3 URL. might boost performance slightly
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: ad77743

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for solid-start-landing-page failed. Why did it fail? →

Name Link
🔨 Latest commit ad77743
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6923471c7e4bed00082a33bc

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2009

commit: 6962521

huseeiin added 2 commits November 22, 2025 20:35
@huseeiin
Copy link
Contributor Author

there are other places i missed because they're more complex. like line 230 in server-functions-handler.ts

@brenelz
Copy link
Contributor

brenelz commented Nov 22, 2025

Some conflicts

Copy link
Member

@atilafassina atilafassina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you pull main to fix the conflicts, the CI will be able to run properly and go, I hope .

could you do that, pls??

@huseeiin
Copy link
Contributor Author

Once you pull main to fix the conflicts, the CI will be able to run properly and go, I hope .

could you do that, pls??

2025-11-23.12-31-04.mp4

it did nothing. is what i'm doing correct?

@brenelz
Copy link
Contributor

brenelz commented Nov 23, 2025

I think that would just pull from your forks main maybe? Need to sync your fork with the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants