Skip to content

Conversation

@g-mero
Copy link

@g-mero g-mero commented Dec 23, 2025

To fix #2040

Changes

  1. Use JSON.stringify at vite-define so backslashes on Windows are escaped
  2. Replace normalize with normalizePath, to fix invalid path on windows

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

🦋 Changeset detected

Latest commit: c496678

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 23, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit c496678
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/696051a799b25500076ec873
😎 Deploy Preview https://deploy-preview-2041--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2041
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2041

commit: c496678

@atilafassina
Copy link
Member

Thanks for the PR @g-mero , would you please add a changeset with a minor bump?

@g-mero
Copy link
Author

g-mero commented Jan 9, 2026

Thanks for the PR @g-mero , would you please add a changeset with a minor bump?

Ok, now it is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: [2.0.0-alpha.1] Build failed on Windows

3 participants