add the ability to configure carmen imported countries#4424
Closed
BenMorganIO wants to merge 1 commit intosolidusio:mainfrom
Closed
add the ability to configure carmen imported countries#4424BenMorganIO wants to merge 1 commit intosolidusio:mainfrom
BenMorganIO wants to merge 1 commit intosolidusio:mainfrom
Conversation
BenMorganIO
force-pushed
the
configure-carmen-seeds
branch
from
9a11722 to
ba539e7
Compare
BenMorganIO
commented
Jun 14, 2022
| # find entries already in the database (so that we may ignore them) | ||
| existing_country_isos = | ||
| Spree::Country.where(iso: carmen_countries.map(&:alpha_2_code)).pluck(:iso) | ||
| Spree::Country.where(iso: selected_countries.map(&:alpha_2_code)).pluck(:iso) |
Contributor
Author
There was a problem hiding this comment.
This is actually redundant because you can just ON CONFLICT DO NOTHING lol but probably useful for logging.
Contributor
|
Thanks, @BenMorganIO! Do you think it'd make sense to use the already available |
Contributor
|
@jarednorman please close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to filter which countries Carmen imports.
Checklist: