[Admin] Add Select address dropdown feature to billing and shipping forms
#5507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_api
rainerdema
force-pushed
the
rainerd/admin/order/select-address-feature
branch
from
41adfce to
84d2337
Compare
github-actions
bot
removed
changelog:solidus_api
rainerdema
force-pushed
the
rainerd/admin/order/select-address-feature
branch
2 times, most recently
from
56fe8ee to
db5b0fd
Compare
rainerdema
force-pushed
the
rainerd/admin/order/select-address-feature
branch
from
db5b0fd to
a918989
Compare
elia
approved these changes
Nov 15, 2023
Member
elia
left a comment
elia
left a comment
There was a problem hiding this comment.
Left some optional suggestions 🙌
admin/app/components/solidus_admin/ui/forms/address/component.rb
Outdated
Show resolved
Hide resolved
admin/app/components/solidus_admin/ui/forms/address/component.rb
Outdated
Show resolved
Hide resolved
admin/app/components/solidus_admin/orders/show/address/component.html.erb
Outdated
Show resolved
Hide resolved
rainerdema
force-pushed
the
rainerd/admin/order/select-address-feature
branch
from
a918989 to
6bea277
Compare
rainerdema
force-pushed
the
rainerd/admin/order/select-address-feature
branch
2 times, most recently
from
3efd79f to
f4867db
Compare
Updated `ui/forms/field` to support string form names and objects, in addition to form objects. Added `extract_form_details` method for handling argument extraction and validation.
Revisited the address handling in the controller by removing the `new` action and consolidating its functionality into the `show` action. The show action now manages rendering of addresses by checking for: 1. an existing `address_id` parameter 2. using the order's address 3. or building a new, non-persistent address.
rainerdema
force-pushed
the
rainerd/admin/order/select-address-feature
branch
from
f4867db to
dcacc85
Compare
Implemented the functionality for the 'Select Address' feature. This addition includes dynamic handling of address selection, enabling users to pick from a list of existing associated addresses.
rainerdema
force-pushed
the
rainerd/admin/order/select-address-feature
branch
from
dcacc85 to
4e053bf
Compare
Fixed an issue where `new_record?` was called on a non-existent address associated with an order object, leading to an "undefined method" error. The problem was identified as the loss of a newly built address after a page refresh, caused by the address selection process retrieving the address without assigning it to the order.
rainerdema
force-pushed
the
rainerd/admin/order/select-address-feature
branch
from
b372321 to
c0b9942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: