Closed
Conversation
github-actions
bot
added
changelog:repository
tvdeyen
force-pushed
the
tackle-rails-7.2-deprecations
branch
from
40ebaac to
c333192
Compare
In order to tackle deprecations one by one
This is the Rails default. From the docs > Eager loading loads your whole application. When running a single test locally, > this probably isn't necessary. It's a good idea to do in a continuous integration > system, or in some way before deploying your code.
tvdeyen
force-pushed
the
tackle-rails-7.2-deprecations
branch
from
c333192 to
3992e39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6009 +/- ##
==========================================
+ Coverage 89.28% 90.16% +0.88%
==========================================
Files 813 813
Lines 17906 17832 -74
==========================================
+ Hits 15987 16078 +91
+ Misses 1919 1754 -165 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Jan 24, 2025
jarednorman
approved these changes
Jan 27, 2025
Contributor
|
@jarednorman can we merge this? |
Member
Author
|
Not necessary anymore now that we merged #6091 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to tackle deprecations one by one