[Backend] Fix issue refunding uncompleted payments

[jtapia]

Summary

• Remove Refund button for uncompleted payments
• Remove Credit button for payment on void and invalid state

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I agree that my PR will be published under the same license as Solidus.
• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[jtapia]

In favor of #2932

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (a57f0c9) to head (4b11b05).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6094      +/-   ##
==========================================
- Coverage   88.82%   86.64%   -2.19%     
==========================================
  Files         835      514     -321     
  Lines       18149    11891    -6258     
==========================================
- Hits        16121    10303    -5818     
+ Misses       2028     1588     -440     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fthobe]

Hey @jtapia thank you for picking this up again after so much time. Seems cov was flaky. Thank you so much!

[jtapia]

@fthobe I believe the broken test is a flaky one. Could someone help me re-running the process on CircleCI?

[kennyadsl]

Hey @jtapia thanks for contributing. Can you put a :flaky on the spec definition that fails? This way we will be covered next time it happens. Thanks!

See

solidus/backend/spec/features/admin/users_spec.rb

Line 471 in ca1ae4d

it 'prefills the customer addresses with the user addresses', :flaky do

and

solidus/core/lib/spree/testing_support/flaky.rb

Line 15 in ca1ae4d

config.around(:each, :flaky) do |example|

.

Thanks!

[jtapia]

@kennyadsl thanks, I have made the changes here: https://github.com/solidusio/solidus/pull/6094/files#diff-b8b2f84275223ed3dc20600049f3eba20911f6e12ed489c34be875590e272599R76, I noticed that codecov is still showing a decrease in coverage, even though it was only a view code change. Is there anything might be missing?

[kennyadsl]

@jtapia thanks! If the view contains logic, it's perfectly legit for codecov to compute the coverage there. It means that we added some conditional paths that are not currently tested.

[fthobe]

@tvdeyen we just closed an I believe 4 year old ticket with that 😅😅😅 @jtapia thank you so much for picking that up again.

[fthobe]

@kennyadsl ready to be merged

[fthobe]

@tvdeyen is there anything left to do or is this ok?

[tvdeyen]

@tvdeyen is there anything left to do or is this ok?

A second approval from @solidusio/core-team

[fthobe]

@tvdeyen can we merge this given that requirements have been met. It's open for too much time.