Fixed wording, typos, license notice & linked to migration guide#6106
Merged
elia merged 2 commits intosolidusio:mainfrom Feb 10, 2025
Merged
Fixed wording, typos, license notice & linked to migration guide#6106elia merged 2 commits intosolidusio:mainfrom
elia merged 2 commits intosolidusio:mainfrom
Conversation
Following changes have been made: - given that the license is identical to parent repository, licensed under was changed - integrated link to migration guide - fixed some wording to give a more positive drive - fixed some typos
github-actions
bot
added
the
changelog:solidus_promotions
Closed
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6106 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 829 829
Lines 17992 17992
=======================================
Hits 15959 15959
Misses 2033 2033 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@elia can we merge this, it's only documentation |
elia
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following changes have been made:
Concerns (but doesn't fully fix yet) #6095
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: