Skip to content

Fix field container identifier on admin stock location#6107

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
SuperGoodSoft:fix-typo-in-stock-location-form-partial
Feb 10, 2025
Merged

Fix field container identifier on admin stock location#6107
tvdeyen merged 1 commit intosolidusio:mainfrom
SuperGoodSoft:fix-typo-in-stock-location-form-partial

Conversation

@forkata
Copy link
Contributor

@forkata forkata commented Feb 7, 2025

Summary

The address1 container incorrectly had the same identifier as the
"Check stock on transfer" input checkbox. This fixes the typo, so this
container can be referenced in Deface overrides, etc.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@forkata forkata requested a review from a team as a code owner February 7, 2025 23:11
The `address1` container incorrectly had the same identifier as the
"Check stock on transfer" input checkbox. This fixes the typo, so this
container can be referenced in Deface overrides, etc.

Co-authored-by: Benjamin Willems <benjamin@super.gd>
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Feb 7, 2025
@forkata forkata force-pushed the fix-typo-in-stock-location-form-partial branch from 3f4b672 to 72af4a8 Compare February 7, 2025 23:12
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (b367f99) to head (72af4a8).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6107   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files         829      829           
  Lines       17992    17992           
=======================================
  Hits        15959    15959           
  Misses       2033     2033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Thanks

@tvdeyen tvdeyen merged commit ec1c421 into solidusio:main Feb 10, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_backend Changes to the solidus_backend gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants