Add primary Taxon to products (#6047)

[fthobe]

Summary

Concerns #6047
Concerns Starter_Frontend #390 #450

Caution

To implement this feature on starter_frontend also #418 needs to be merged.

This PR fixes outcome variability on the breadcrumbs rendered on the frontpage and is part of a couple of PRs addressing the lack of some SEO features that became prevalent.

Issue: Breadcrumbs are not rendered reliably given that any of multiple taxons can be used

Breadcrumbs are used to tell search engines more about the overal page structure of a website. Currently the starter frontend pulls the first taxon identified on the website and renders that including all ancestors as breadcrumbs terminating the trail with the current page.

While this renders valid breadcrumbs (opposite to some other pages) it does neccessarily reinforce the desired keyword as the taxon rendered as breadcrumb does not always reflect the keyword desired.

To solve that issue @shahmayur001 implemented an additional instrument to select the desired breadcrumb taxon in the admin interface.

Fixes #6047

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I agree that my PR will be published under the same license as Solidus.
• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base (95a9ea8) to head (f35f325).
Report is 14 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6109      +/-   ##
==========================================
- Coverage   88.68%   86.63%   -2.06%     
==========================================
  Files         830      512     -318     
  Lines       18013    11819    -6194     
==========================================
- Hits        15975    10239    -5736     
+ Misses       2038     1580     -458     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fthobe]

@elia ready as discussed in #6047

[fthobe]

@shahmayur001 if you rebase I add the open api description

[kennyadsl]

Thanks. I left a comment on the placeholder. Also, do we need to add the same field in the new admin products/show?

[fthobe]

I would yes

[fthobe]

It would be great to know if we still care about the old admin? Are new features still supported on it?

[kennyadsl]

@fthobe right now there is no edit page for products in the new admin, so we need to put them in the old one.

[fthobe]

Why? Seriously I am not arguing here, if the product editing page is ready let's use that one.

Please pick one of these

• new features new admin
• new features old and new if page present
• new features old admin

[tvdeyen]

Why? Seriously I am not arguing here, if the product editing page is ready let's use that one.

Please pick one of these

The new admin is still in beta (and will probably be for a long time).

We still need to support the old current admin.

So

• new features new admin
• new features old and new if page present
• new features old admin

and let's please use "current admin" as name for the current admin. It will be old (and obsolete) the moment we consider the new admin stable and ship it as default.

[fthobe]

Ok that's a clear statement. @shahmayur001

[kennyadsl]

Approved, but I just noticed we didn't add the primary taxon to sample products. Ok for me to add it in another PR if needed. Up to you!

[fthobe]

I would actually make some adjustments to starter regarding brands and make one run on sample data as a total as we need it to test structured data. Is that acceptable for everybody?

[tvdeyen]

Great work @shahmayur001

I have to change requests, then this can be merged.

[tvdeyen]

Thanks. I just saw that the taxonAutocomplete jQuery function has been renamed for no obvious reason. Please revert this change or provide good reasons for the change and add backwards compatibility.

Also please create a dedicated commit that introduces the changes for the options that now can be passed in. This is a welcome change, but it needs a separate commit at least.

[fthobe]

@tvdeyen sorry for the mixup with the jscript, should be fine now.

Test seems flaky, should I open a ticket to add a retry to

rspec ./spec/features/admin/orders/return_payment_state_spec.rb:70 # Return payment state spec disables the "Create Reimbursement" button at submit

[tvdeyen]

Thanks.

[tvdeyen]

Reran flaky spec. But this is unrelated