Revert "Merge pull request #6122 from mamhoff/create-manifest-js-in-g… #6124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6124 +/- ##
=======================================
Coverage 88.67% 88.68%
=======================================
Files 830 830
Lines 18016 18014 -2
=======================================
Hits 15976 15976
+ Misses 2040 2038 -2 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
Feb 17, 2025
|
Or we wait for rails/sprockets-rails#546 to be merged and released? |
tvdeyen
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enerated-apps"
This reverts commit bec42f6, reversing changes made to 37a5c8a.
Summary
This reverts #6122. If Rails 8 runs the install generator, the Rails process won't even start if the file is not present, and consequently our installer won't run either. The actual fix is this: solidusio/solidus_dev_support#229 - The sprockets manifest file needs to be present before even starting up a Rails process with Solidus in the Gemfile.
I guess we need to sort out the Sprockets removal next.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: