Skip to content

Fix sandbox command for Rails 8#6133

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
blish:fix-sandbox-rails8
Feb 19, 2025
Merged

Fix sandbox command for Rails 8#6133
tvdeyen merged 1 commit intosolidusio:mainfrom
blish:fix-sandbox-rails8

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Feb 18, 2025

Summary

Rails 8 does not create a sprockets manifest anymore, but we still depend on it. Since rails commands do not work anymore, because sprockets raises an error if no manifest.js file is present we need to create it in order to be able to run rails new

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Rails 8 does not create a sprockets manifest anymore,
but we still depend on it. Since rails commands do not
work anymore, because sprockets raises an error if no
manifest.js file is present we need to create it in
order to be able to run rails new
@tvdeyen tvdeyen requested a review from a team as a code owner February 18, 2025 14:56
@tvdeyen tvdeyen added this to the 4.5 milestone Feb 18, 2025
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Feb 18, 2025
@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (4a892c3) to head (a7f0011).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6133   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files         835      835           
  Lines       18146    18146           
=======================================
  Hits        16116    16116           
  Misses       2030     2030           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennyadsl
Copy link
Member

Thanks @tvdeyen! Do we need this here as well?

@tvdeyen
Copy link
Member Author

tvdeyen commented Feb 19, 2025

Thanks @tvdeyen! Do we need this here as well?

Yes, it's done in solidusio/solidus_dev_support@1949ffc

@tvdeyen tvdeyen merged commit a85e0be into solidusio:main Feb 19, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants