Skip to content

Refactor address form component (properly this time) #6225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdeyen merged 5 commits into from
May 13, 2025

Remove redundant initializer

e45cec2
Select commit
Loading
Failed to load commit list.
Merged

Refactor address form component (properly this time) #6225

Remove redundant initializer
e45cec2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 12, 2025 in 1s

88.75% (+2.22%) compared to a85ae3c

View this Pull Request on Codecov

88.75% (+2.22%) compared to a85ae3c

Details

Codecov Report

Attention: Patch coverage is 79.54545% with 18 lines in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (a85ae3c) to head (e45cec2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...n/ui/forms/address/fieldsets/location/component.rb 0.00% 12 Missing ⚠️
...ponents/concerns/solidus_admin/slotable_default.rb 77.77% 4 Missing ⚠️
...onents/solidus_admin/ui/forms/address/component.rb 90.00% 1 Missing ⚠️
...s/solidus_admin/ui/forms/address/fieldsets/base.rb 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6225      +/-   ##
==========================================
+ Coverage   86.53%   88.75%   +2.22%     
==========================================
  Files         520      849     +329     
  Lines       11947    18326    +6379     
==========================================
+ Hits        10338    16265    +5927     
- Misses       1609     2061     +452

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov