Fix linting errors

.rubocop.yml

@@ -348,6 +348,15 @@ Rails/FindEach:
   Exclude:
     - "db/migrate/**/*"
 
+Rails/LexicallyScopedActionFilter:
+  Exclude:
+    - "backend/app/controllers/**/*"
+
+Rails/HelperInstanceVariable:
+  Exclude:
+    - "backend/app/helpers/**/*"
+    - "core/app/helpers/**/*"
+
 # Since we're writing library code we can't assume that
 # tasks should load the rails environment loaded.
 Rails/RakeEnvironment:

core/app/models/concerns/spree/user_methods.rb

@@ -11,20 +11,58 @@ module UserMethods
     included do
       extend Spree::DisplayMoney
 
-      has_many :role_users, foreign_key: "user_id", class_name: "Spree::RoleUser", dependent: :destroy
-      has_many :spree_roles, through: :role_users, source: :role, class_name: "Spree::Role"
-
-      has_many :user_stock_locations, foreign_key: "user_id", class_name: "Spree::UserStockLocation"
-      has_many :stock_locations, through: :user_stock_locations
-
-      has_many :spree_orders, foreign_key: "user_id", class_name: "Spree::Order"
-      has_many :orders, foreign_key: "user_id", class_name: "Spree::Order"
-
-      has_many :store_credits, -> { includes(:credit_type) }, foreign_key: "user_id", class_name: "Spree::StoreCredit"
-      has_many :store_credit_events, through: :store_credits
-
-      has_many :credit_cards, class_name: "Spree::CreditCard", foreign_key: :user_id
-      has_many :wallet_payment_sources, foreign_key: 'user_id', class_name: 'Spree::WalletPaymentSource', inverse_of: :user
+      has_many :role_users,
+        foreign_key: "user_id",
+        class_name: "Spree::RoleUser",
+        dependent: :destroy,
+        inverse_of: :user
+      has_many :spree_roles,
+        through: :role_users,
+        source: :role,
+        class_name: "Spree::Role",
+        inverse_of: :users
+
+      has_many :user_stock_locations,
+        foreign_key: "user_id",
+        class_name: "Spree::UserStockLocation",
+        inverse_of: :user,
+        dependent: :destroy
+      has_many :stock_locations,
+        through: :user_stock_locations,
+        inverse_of: :users
+
+      has_many :spree_orders,
+        foreign_key: "user_id",
+        class_name: "Spree::Order",
+        inverse_of: :user,
+        dependent: :nullify
+      has_many :orders,
+        foreign_key: "user_id",
+        class_name: "Spree::Order",
+        inverse_of: :user,
+        dependent: :nullify
+
+      has_many :store_credits,
+        -> { includes(:credit_type) },
+        foreign_key: "user_id",
+        class_name: "Spree::StoreCredit",
+        dependent: :nullify,
+        inverse_of: :user
+      has_many :store_credit_events,
+        through: :store_credits,
+        inverse_of: false
+
+      has_many :credit_cards,
+        class_name: "Spree::CreditCard",
+        foreign_key: :user_id,
+        dependent: :nullify,
+        inverse_of: :user
+
+      has_many :wallet_payment_sources,
+        foreign_key: 'user_id',
+        class_name: 'Spree::WalletPaymentSource',
+        inverse_of: :user,
+        dependent: :destroy
 
       after_create :auto_generate_spree_api_key
       before_destroy :check_for_deletion

core/app/models/spree/adjustment_reason.rb

@@ -2,7 +2,7 @@
 
 module Spree
   class AdjustmentReason < Spree::Base
-    has_many :adjustments, inverse_of: :adjustment_reason
+    has_many :adjustments, inverse_of: :adjustment_reason, dependent: :restrict_with_exception
 
     validates :name, presence: true, uniqueness: { case_sensitive: false, allow_blank: true }
     validates :code, presence: true, uniqueness: { case_sensitive: false, allow_blank: true }

core/app/models/spree/country.rb

@@ -2,9 +2,19 @@
 
 module Spree
   class Country < Spree::Base
-    has_many :states, -> { order(:name) }, dependent: :destroy
-    has_many :addresses, dependent: :nullify
-    has_many :prices, class_name: "Spree::Price", foreign_key: "country_iso", primary_key: "iso"
+    has_many :states,
+      -> { order(:name) },
+      dependent: :destroy,
+      inverse_of: :country
+    has_many :addresses,
+      dependent: :nullify,
+      inverse_of: false
+    has_many :prices,
+      class_name: "Spree::Price",
+      foreign_key: "country_iso",
+      primary_key: "iso",
+      dependent: :destroy,
+      inverse_of: :country
 
     validates :name, :iso_name, presence: true
 

core/app/models/spree/credit_card.rb

@@ -4,7 +4,11 @@ module Spree
   # The default `source` of a `Spree::Payment`.
   #
   class CreditCard < Spree::PaymentSource
-    belongs_to :user, class_name: Spree::UserClassHandle.new, foreign_key: 'user_id', optional: true
+    belongs_to :user,
+      class_name: Spree::UserClassHandle.new,
+      foreign_key: 'user_id',
+      optional: true,
+      inverse_of: :credit_cards
     belongs_to :address, optional: true
 
     before_save :set_last_digits

core/app/models/spree/customer_return.rb

@@ -6,9 +6,14 @@ class CustomerReturn < Spree::Base
 
     belongs_to :stock_location, optional: true
 
-    has_many :return_items, inverse_of: :customer_return
-    has_many :return_authorizations, through: :return_items
-    has_many :reimbursements, inverse_of: :customer_return
+    has_many :return_items,
+      inverse_of: :customer_return,
+      dependent: :destroy
+    has_many :return_authorizations,
+      through: :return_items
+    has_many :reimbursements,
+      inverse_of: :customer_return,
+      dependent: :nullify
 
     after_create :process_return!
     before_create :generate_number

core/app/models/spree/inventory_unit.rb

@@ -13,10 +13,20 @@ class InventoryUnit < Spree::Base
     belongs_to :carton, class_name: "Spree::Carton", inverse_of: :inventory_units, optional: true
     belongs_to :line_item, class_name: "Spree::LineItem", inverse_of: :inventory_units, optional: true
 
-    has_many :return_items, inverse_of: :inventory_unit, dependent: :destroy
-    has_one :original_return_item, class_name: "Spree::ReturnItem", foreign_key: :exchange_inventory_unit_id, dependent: :destroy
-    has_one :unit_cancel, class_name: "Spree::UnitCancel"
-    has_one :order, through: :shipment
+    has_many :return_items,
+      inverse_of: :inventory_unit,
+      dependent: :destroy
+    has_one :original_return_item,
+      class_name: "Spree::ReturnItem",
+      foreign_key: :exchange_inventory_unit_id,
+      dependent: :destroy,
+      inverse_of: :exchange_inventory_unit
+    has_one :unit_cancel,
+      class_name: "Spree::UnitCancel",
+      inverse_of: :inventory_unit,
+      dependent: :restrict_with_exception
+    has_one :order,
+      through: :shipment
 
     delegate :order_id, to: :shipment
 

core/app/models/spree/line_item.rb

@@ -19,7 +19,7 @@ class LineItem < Spree::Base
     has_one :product, through: :variant
 
     has_many :adjustments, as: :adjustable, inverse_of: :adjustable, dependent: :destroy
-    has_many :inventory_units, inverse_of: :line_item
+    has_many :inventory_units, inverse_of: :line_item, dependent: false
 
     before_validation :normalize_quantity
     before_validation :set_required_attributes

core/app/models/spree/order.rb

@@ -75,11 +75,19 @@ class CannotRebuildShipments < StandardError; end
     # Customer info
     belongs_to :user, class_name: Spree::UserClassHandle.new, optional: true
 
-    belongs_to :bill_address, foreign_key: :bill_address_id, class_name: 'Spree::Address', optional: true
+    belongs_to :bill_address,
+      foreign_key: :bill_address_id,
+      class_name: 'Spree::Address',
+      optional: true,
+      inverse_of: false
     alias_method :billing_address, :bill_address
     alias_method :billing_address=, :bill_address=
 
-    belongs_to :ship_address, foreign_key: :ship_address_id, class_name: 'Spree::Address', optional: true
+    belongs_to :ship_address,
+      foreign_key: :ship_address_id,
+      class_name: 'Spree::Address',
+      optional: true,
+      inverse_of: false
     alias_method :shipping_address, :ship_address
     alias_method :shipping_address=, :ship_address=
 
@@ -113,17 +121,22 @@ def states
 
     # Payments
     has_many :payments, dependent: :destroy, inverse_of: :order
-    has_many :valid_store_credit_payments, -> { store_credits.valid }, inverse_of: :order, class_name: 'Spree::Payment', foreign_key: :order_id
+    has_many :valid_store_credit_payments,
+      -> { store_credits.valid },
+      inverse_of: :order,
+      class_name: 'Spree::Payment',
+      foreign_key: :order_id,
+      dependent: :destroy
 
     # Returns
     has_many :return_authorizations, dependent: :destroy, inverse_of: :order
     has_many :return_items, through: :inventory_units
     has_many :customer_returns, -> { distinct }, through: :return_items
-    has_many :reimbursements, inverse_of: :order
+    has_many :reimbursements, inverse_of: :order, dependent: :restrict_with_exception
     has_many :refunds, through: :payments
 
     # Logging
-    has_many :state_changes, as: :stateful
+    has_many :state_changes, as: :stateful, dependent: :destroy
     belongs_to :created_by, class_name: Spree::UserClassHandle.new, optional: true
     belongs_to :approver, class_name: Spree::UserClassHandle.new, optional: true
     belongs_to :canceler, class_name: Spree::UserClassHandle.new, optional: true

core/app/models/spree/payment.rb

@@ -17,10 +17,10 @@ class Payment < Spree::Base
     belongs_to :source, polymorphic: true, optional: true
     belongs_to :payment_method, -> { with_discarded }, class_name: 'Spree::PaymentMethod', inverse_of: :payments, optional: true
 
-    has_many :log_entries, as: :source
-    has_many :state_changes, as: :stateful
-    has_many :capture_events, class_name: 'Spree::PaymentCaptureEvent'
-    has_many :refunds, inverse_of: :payment
+    has_many :log_entries, as: :source, dependent: :destroy
+    has_many :state_changes, as: :stateful, dependent: :destroy
+    has_many :capture_events, class_name: 'Spree::PaymentCaptureEvent', dependent: :destroy
+    has_many :refunds, inverse_of: :payment, dependent: :destroy
 
     before_validation :validate_source, unless: :invalid?
     before_create :set_unique_identifier

core/app/models/spree/payment_method.rb

@@ -23,9 +23,9 @@ class UnsupportedPaymentMethod < StandardError; end
 
     validates :name, :type, presence: true
 
-    has_many :payments, class_name: "Spree::Payment", inverse_of: :payment_method
-    has_many :credit_cards, class_name: "Spree::CreditCard"
-    has_many :store_payment_methods, inverse_of: :payment_method
+    has_many :payments, class_name: "Spree::Payment", inverse_of: :payment_method, dependent: :restrict_with_exception
+    has_many :credit_cards, class_name: "Spree::CreditCard", dependent: :restrict_with_exception
+    has_many :store_payment_methods, inverse_of: :payment_method, dependent: :destroy
     has_many :stores, through: :store_payment_methods
 
     scope :ordered_by_position, -> { order(:position) }

core/app/models/spree/payment_source.rb

@@ -6,7 +6,7 @@ class PaymentSource < Spree::Base
 
     belongs_to :payment_method, optional: true
 
-    has_many :payments, as: :source
+    has_many :payments, as: :source, dependent: :restrict_with_error
     has_many :wallet_payment_sources,
       class_name: 'Spree::WalletPaymentSource',
       as: :payment_source,

core/app/models/spree/permission_set.rb

@@ -2,7 +2,7 @@
 
 module Spree
   class PermissionSet < Spree::Base
-    has_many :role_permissions
+    has_many :role_permissions, dependent: :destroy
     has_many :roles, through: :role_permissions
     validates :name, :set, :privilege, :category, presence: true
     scope :display_permissions, -> { where(privilege: "display") }

core/app/models/spree/price.rb

@@ -6,8 +6,18 @@ class Price < Spree::Base
 
     MAXIMUM_AMOUNT = BigDecimal('99_999_999.99')
 
-    belongs_to :variant, -> { with_discarded }, class_name: 'Spree::Variant', touch: true, optional: true
-    belongs_to :country, class_name: "Spree::Country", foreign_key: "country_iso", primary_key: "iso", optional: true
+    belongs_to :variant,
+      -> { with_discarded },
+      class_name: 'Spree::Variant',
+      touch: true,
+      optional: true,
+      inverse_of: :prices
+    belongs_to :country,
+      class_name: "Spree::Country",
+      foreign_key: "country_iso",
+      primary_key: "iso",
+      optional: true,
+      inverse_of: :prices
 
     delegate :product, to: :variant
     delegate :tax_rates, to: :variant

core/app/models/spree/refund.rb

@@ -5,10 +5,14 @@ class Refund < Spree::Base
     include Metadata
 
     belongs_to :payment, inverse_of: :refunds, optional: true
-    belongs_to :reason, class_name: 'Spree::RefundReason', foreign_key: :refund_reason_id, optional: true
+    belongs_to :reason,
+      class_name: 'Spree::RefundReason',
+      foreign_key: :refund_reason_id,
+      optional: true,
+      inverse_of: :refunds
     belongs_to :reimbursement, inverse_of: :refunds, optional: true
 
-    has_many :log_entries, as: :source
+    has_many :log_entries, as: :source, dependent: :destroy
 
     validates :payment, presence: true
     validates :reason, presence: true

core/app/models/spree/refund_reason.rb

@@ -9,7 +9,7 @@ class RefundReason < Spree::Base
 
     RETURN_PROCESSING_REASON = 'Return processing'
 
-    has_many :refunds
+    has_many :refunds, dependent: :restrict_with_error
 
     self.allowed_ransackable_attributes = %w[name code]
 

core/app/models/spree/reimbursement.rb

@@ -7,10 +7,17 @@ class IncompleteReimbursementError < StandardError; end
     belongs_to :order, inverse_of: :reimbursements, optional: true
     belongs_to :customer_return, inverse_of: :reimbursements, touch: true, optional: true
 
-    has_many :refunds, inverse_of: :reimbursement
-    has_many :credits, inverse_of: :reimbursement, class_name: 'Spree::Reimbursement::Credit'
-
-    has_many :return_items, inverse_of: :reimbursement
+    has_many :refunds,
+      inverse_of: :reimbursement,
+      dependent: :restrict_with_error
+    has_many :credits,
+      inverse_of: :reimbursement,
+      class_name: 'Spree::Reimbursement::Credit',
+      dependent: :restrict_with_error
+
+    has_many :return_items,
+      inverse_of: :reimbursement,
+      dependent: :restrict_with_error
 
     validates :order, presence: true
     validate :validate_return_items_belong_to_same_order

core/app/models/spree/reimbursement_type.rb

@@ -9,7 +9,7 @@ class ReimbursementType < Spree::Base
 
     ORIGINAL = 'original'
 
-    has_many :return_items
+    has_many :return_items, dependent: :restrict_with_error
 
     self.allowed_ransackable_attributes = %w[name]
 

core/app/models/spree/return_authorization.rb

@@ -13,7 +13,11 @@ class ReturnAuthorization < Spree::Base
     has_many :customer_returns, through: :return_items
 
     belongs_to :stock_location, optional: true
-    belongs_to :reason, class_name: 'Spree::ReturnReason', foreign_key: :return_reason_id, optional: true
+    belongs_to :reason,
+      class_name: 'Spree::ReturnReason',
+      foreign_key: :return_reason_id,
+      optional: true,
+      inverse_of: :return_authorizations
 
     before_create :generate_number
 

core/app/models/spree/return_item.rb

@@ -37,7 +37,11 @@ class ReturnItem < Spree::Base
     belongs_to :reimbursement, inverse_of: :return_items, optional: true
     belongs_to :preferred_reimbursement_type, class_name: 'Spree::ReimbursementType', optional: true
     belongs_to :override_reimbursement_type, class_name: 'Spree::ReimbursementType', optional: true
-    belongs_to :return_reason, class_name: 'Spree::ReturnReason', foreign_key: :return_reason_id, optional: true
+    belongs_to :return_reason,
+      class_name: 'Spree::ReturnReason',
+      foreign_key: :return_reason_id,
+      optional: true,
+      inverse_of: false
 
     validate :eligible_exchange_variant
     validate :belongs_to_same_customer_order

core/app/models/spree/return_reason.rb

@@ -7,7 +7,7 @@ class ReturnReason < Spree::Base
 
     validates :name, presence: true, uniqueness: { case_sensitive: false, allow_blank: true }
 
-    has_many :return_authorizations
+    has_many :return_authorizations, dependent: :restrict_with_error
 
     self.allowed_ransackable_attributes = %w[name]