Skip to content

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented May 29, 2025

Summary

We use firefox for testing, so we should not need Chrome.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@mamhoff mamhoff requested a review from a team as a code owner May 29, 2025 12:36
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label May 29, 2025
@tvdeyen tvdeyen enabled auto-merge May 29, 2025 12:57
We use firefox for testing, so we should not need Chrome.
@tvdeyen tvdeyen merged commit 74dd6f4 into solidusio:main May 29, 2025
21 of 22 checks passed
@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (284fe3d) to head (e46f250).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6249   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files         850      850           
  Lines       18328    18328           
=======================================
  Hits        16281    16281           
  Misses       2047     2047           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen added backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 backport-v4.5 Backport this pull-request to v4.5 labels May 30, 2025
@github-actions
Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- CI: Lint code on GH actions
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- CI: Lint code on GH actions
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.5:
- CI: Lint code on GH actions

Manual backport

To create the backport manually run:

backport --pr 6249

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- CI: Lint code on GH actions
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- CI: Lint code on GH actions
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.5:
- CI: Lint code on GH actions

Manual backport

To create the backport manually run:

backport --pr 6249

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- CI: Lint code on GH actions
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- CI: Lint code on GH actions
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.5:
- CI: Lint code on GH actions

Manual backport

To create the backport manually run:

backport --pr 6249

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- CI: Lint code on GH actions
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- CI: Lint code on GH actions
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.5:
- CI: Lint code on GH actions

Manual backport

To create the backport manually run:

backport --pr 6249

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- CI: Lint code on GH actions
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- CI: Lint code on GH actions
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 Backport failed because of merge conflicts
v4.5 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.5:
- CI: Lint code on GH actions

Manual backport

To create the backport manually run:

backport --pr 6249

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen tvdeyen removed backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 labels May 30, 2025
@tvdeyen
Copy link
Member

tvdeyen commented May 30, 2025

💚 All backports created successfully

Status Branch Result
v4.5

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.5 Backport this pull-request to v4.5 changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants