-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Admin users edit tabs #6252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin users edit tabs #6252
Conversation
53838ea to
22f6a90
Compare
This will be used in all user edit pages, so that each page does not have to repeatedly define the tabs and translations.
Updates user edit pages to use shared tabs component, removing #tabs methods from each and tab related translations. Order history and Store credits still use :order_history and :store_credit respectively in their templates.
This has been moved to `stats` component.
22f6a90 to
fda42f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6252 +/- ##
==========================================
- Coverage 88.82% 88.82% -0.01%
==========================================
Files 850 851 +1
Lines 18334 18332 -2
==========================================
- Hits 16286 16284 -2
Misses 2048 2048 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@tvdeyen this should fix the issue with duplicating translation keys, but i'm not sure the way they posted it in the discussion works?
the lookup for the keys would be I've tried switching locale to :fr and adding a french locale file in sandbox app, it works fine with this scope I have a question though, if one would want to override the |
|
Thanks
I would have imagined the same. @kennyadsl can you help out? |
tvdeyen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes much sense.
Closes #6242
Summary
Moved tabs from user edit pages into its own component. This allows to remove repetitive
tabsdefinitions and translations.Also removed a redundant translation that has been moved to a different component.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: