Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 30, 2025

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen self-assigned this May 30, 2025
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label May 30, 2025
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (f0a7456) to head (6e809cb).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6266   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files         850      850           
  Lines       18334    18334           
=======================================
  Hits        16286    16286           
  Misses       2048     2048           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the github-actions branch 12 times, most recently from 35b09be to c35491c Compare May 30, 2025 21:00
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem and removed changelog:repository Changes to the repository not within any gem labels May 30, 2025
tvdeyen added 2 commits May 31, 2025 18:04
We want to write into the `test.log` instead, which rspec/rails
already set up for us.
@tvdeyen tvdeyen force-pushed the github-actions branch 2 times, most recently from 03fc796 to 2e8003e Compare May 31, 2025 16:07
@tvdeyen
Copy link
Member Author

tvdeyen commented May 31, 2025

closed in favor of #6269

@tvdeyen tvdeyen closed this May 31, 2025
@tvdeyen tvdeyen deleted the github-actions branch May 31, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant