Admin sorting with pagination #6267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change we used geared pagination default ratios of [15,30, 50,100] for paging, which is suitable for loading data during infinite scroll but not so much with tabular data, where it is more reasonable to show fixed amount of rows on each page. Here we allow children controllers to override per_page in case they still want to use ratios or define their own fixed `per_page` amounts.
sortable_controller.js will use these in order to correctly calculate new position value.
chaimann
force-pushed
the
admin-sorting-with-pagination
branch
from
09269af to
5d53632
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6267 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 850 850
Lines 18341 18344 +3
=======================================
+ Hits 16291 16294 +3
Misses 2050 2050 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solidus Admin
Summary
Applies offset when updating position of a resource in the sortable table, for sorting to work correctly in tables with more than one page.
For this to be possible, a change is made to resources_controller to introduce fixed default per_page = 20. While geared_pagination promotes ratios to be used with pagination, I don't really see it fitting in the tabular resources as it's not too common to have tables with variable amount of rows.
It is possible for child controllers to override
per_pageif they need to use different number or ratios.Before
Screen.Recording.2025-05-29.at.12.08.38.mov
After
Screen.Recording.2025-05-30.at.18.03.18.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: