Skip to content

Conversation

@chaimann
Copy link
Contributor

@chaimann chaimann commented Jun 2, 2025

Summary

A bit of cleanup for product form:

  • add missing column gap between sections inside a panel
  • add translations instead of raw strings
  • update products controller to explicitly permit a list of params and fix saving multiple related ids by removing #split_params
image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin labels Jun 2, 2025
@chaimann chaimann force-pushed the admin-product-form-improvements branch from 6baba59 to c18edc5 Compare June 2, 2025 12:57
@chaimann chaimann added type:enhancement Proposed or newly added feature and removed type:enhancement Proposed or newly added feature labels Jun 2, 2025
@chaimann chaimann force-pushed the admin-product-form-improvements branch from c18edc5 to 17ee22f Compare June 2, 2025 16:05
@github-actions github-actions bot removed the changelog:solidus_core Changes to the solidus_core gem label Jun 2, 2025
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base (2aed8c3) to head (b4b15bb).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6270      +/-   ##
==========================================
- Coverage   88.86%   86.63%   -2.24%     
==========================================
  Files         857      520     -337     
  Lines       18415    11946    -6469     
==========================================
- Hits        16365    10349    -6016     
+ Misses       2050     1597     -453     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chaimann chaimann marked this pull request as ready for review June 2, 2025 16:46
@chaimann chaimann requested a review from a team as a code owner June 2, 2025 16:46
@tvdeyen tvdeyen moved this to In Progress in Solidus Admin Jun 2, 2025
@tvdeyen tvdeyen moved this from In Progress to Review in Solidus Admin Jun 2, 2025
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

chaimann added 3 commits June 3, 2025 16:56
According to designs each section in panel is expected to have 24px of
column-gap.
Translate strings and reorganize translation keys a bit.
Use explicit product params to permit.
Removes #split_params as not needed because multiple select handles
sending multiple values correctly.
@chaimann chaimann force-pushed the admin-product-form-improvements branch from 17ee22f to b4b15bb Compare June 3, 2025 14:56
@tvdeyen tvdeyen merged commit 13e4fae into solidusio:main Jun 4, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Solidus Admin Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants