Skip to content

Conversation

@chaimann
Copy link
Contributor

@chaimann chaimann commented Jun 4, 2025

Summary

Fixes rubocop offence with duplicate methods, and creates default methods that should be overridden in child classes.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (e6a57c3) to head (a0aca43).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
.../controllers/solidus_admin/resources_controller.rb 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6276      +/-   ##
==========================================
- Coverage   88.87%   88.86%   -0.01%     
==========================================
  Files         858      858              
  Lines       18413    18416       +3     
==========================================
+ Hits        16364    16366       +2     
- Misses       2049     2050       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chaimann chaimann marked this pull request as ready for review June 5, 2025 10:10
@chaimann chaimann requested a review from a team as a code owner June 5, 2025 10:10
@chaimann chaimann changed the title [Admin] resources controller cleanup [Admin] Fix rubocop offence and resources controller cleanup Jun 5, 2025
chaimann added 3 commits June 10, 2025 16:14
#per_page was defined in two separate pull requests, so here let's leave
the one that returns default per page number.
That will raise if child class does not implement its own methods.
@chaimann chaimann force-pushed the admin-resources-controller-cleanup branch from 79218db to a0aca43 Compare June 10, 2025 14:14
@tvdeyen tvdeyen merged commit 6d66dad into solidusio:main Jun 11, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants