Skip to content

Conversation

@chaimann
Copy link
Contributor

@chaimann chaimann commented Jun 5, 2025

Note

Split from #6160

Summary

The "email" field is present on new designs for stock location form, but the column was not in the schema yet.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jun 5, 2025
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (ffa13fc) to head (fd9ad8b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6277   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         860      860           
  Lines       18423    18423           
=======================================
  Hits        16388    16388           
  Misses       2035     2035           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chaimann chaimann force-pushed the admin-add-email-to-stock-locations-migration branch 2 times, most recently from 439814d to 3942ce3 Compare June 11, 2025 11:05
The "email" field is present on new designs for stock location form, but
the column was not in the schema yet.
@chaimann chaimann force-pushed the admin-add-email-to-stock-locations-migration branch from 3942ce3 to fd9ad8b Compare June 11, 2025 11:25
@chaimann chaimann marked this pull request as ready for review June 11, 2025 16:38
@chaimann chaimann requested a review from a team as a code owner June 11, 2025 16:38
@tvdeyen tvdeyen changed the title [Admin] Add email column to stock_locations Add email column to stock_locations Jun 11, 2025
@tvdeyen tvdeyen added this to the 4.6 milestone Jun 11, 2025
@tvdeyen tvdeyen moved this to In Progress in Solidus Public Roadmap Jun 11, 2025
@tvdeyen tvdeyen merged commit fe858ab into solidusio:main Jun 27, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Solidus Public Roadmap Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

Development

Successfully merging this pull request may close these issues.

3 participants