Skip to content

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jun 6, 2025

Summary

New version of Rubocop, new ToDo, new configuration changes. This is just to keep builds clean.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

mamhoff added 2 commits June 6, 2025 09:01
Rubocop came around with new cops, and we have to regenerate to keep the
builds clean.
`Naming/PredicateName` has been renamed to `Naming/PredicatePrefix`.
@mamhoff mamhoff requested a review from a team as a code owner June 6, 2025 07:03
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (13e4fae) to head (c703a3e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6281   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files         858      858           
  Lines       18413    18413           
=======================================
  Hits        16364    16364           
  Misses       2049     2049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kennyadsl
Copy link
Member

Merging, as this is an internal change.

@kennyadsl kennyadsl merged commit e6a57c3 into solidusio:main Jun 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants