Handle failing foreign key additions #6293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6293 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 861 861
Lines 18416 18416
=======================================
Hits 16386 16386
Misses 2030 2030 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
reviewed
Jun 19, 2025
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Nice! Some wrong comments, though
core/db/migrate/20250605105424_add_shipping_category_foreign_keys.rb
Outdated
Show resolved
Hide resolved
mamhoff
force-pushed
the
add-foreign-key-constraint-warnings
branch
2 times, most recently
from
c7481e3 to
7a2794e
Compare
kennyadsl
approved these changes
Jun 25, 2025
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
It should be saf to change these migrations, as if people already ran them without issues, they are safe anyway. If they got some issues, they probably already solved them.
We've added some foreign key constraints recently, and have since come up with a nicer way of guiding users towards fixing their data intentionally. This change gives them a nice error message and allows them to change the migration to remove offending records. Co-Authored-By: [email protected]
mamhoff
force-pushed
the
add-foreign-key-constraint-warnings
branch
from
7a2794e to
55dd557
Compare
tvdeyen
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've added some foreign key constraints recently, and have since come up with a nicer way of guiding users towards fixing their data intentionally.
This change gives them a nice error message and allows them to change the migration to remove offending records.
Co-Authored-By: [email protected]
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: