Match foreign key constraint error causes on exception names#6308
Merged
tvdeyen merged 2 commits intosolidusio:mainfrom Jul 26, 2025
Merged
Match foreign key constraint error causes on exception names#6308tvdeyen merged 2 commits intosolidusio:mainfrom
tvdeyen merged 2 commits intosolidusio:mainfrom
Conversation
When migrating the database in a Solidus context, we usually only have the database adapter loaded that is being used. Rescuing exceptions from other adapters will therefore fail with an "uninitialized constant error". In order to safeguard from this, this commit changes the matching on error class to matching on their name.
The standard way of producing output for users to read in a migration is `ActiveRecord::Migration#say`.
github-actions
bot
added
the
changelog:solidus_core
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We've added pretty sophisticated error handling to the migrations that add foreign keys. When I first hit one of these errors, though, I found that in a Solidus context, only the error classes for the currently used database adapter will be loaded. Because our migrations need to work with all adapters, this PR changes the matching to be on the string name of the exception, rather than on the exception class.
Additionally, this changes the messaging to use
ActiveRecord::Migration#sayrather than directly invokingRails.logger.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: