Closed
Conversation
Instead of instantiating new records directly or using `mock_model`, we can use factories, which are more realistically set up objects. Co-Authored-By: benjamin wil <benjamin@super.gd> Co-Authored-By: Senem Soy <senem@super.gd> Co-Authored-By: Alistair Norman <alistair@super.gd>
github-actions
bot
added
the
changelog:solidus_promotions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6311 +/- ##
=======================================
Coverage ? 89.31%
=======================================
Files ? 959
Lines ? 20116
Branches ? 0
=======================================
Hits ? 17967
Misses ? 2149
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Sorry, opened this too soon. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In our work on the in-memory order updater (#5872), we updated some tests to have more realistic test setup. This is not dependent on that work, so we are splitting it into its own small pull request.
Instead of instantiating new records directly or using
mock_model, we can use factories, which are more realistically set up objects.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: