Skip to content

Use new configuration setting for item total class#6312

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
SuperGoodSoft:use-item-total-configurable-class
Aug 5, 2025
Merged

Use new configuration setting for item total class#6312
tvdeyen merged 1 commit intosolidusio:mainfrom
SuperGoodSoft:use-item-total-configurable-class

Conversation

@benjaminwil
Copy link
Contributor

Summary

In our work on the in-memory order updater (#5872), we created a new configuration point item_total_class, but we did not use this configuration class in the solidus_legacy_promotions gem.

This pull request simply starts using the configuration point instead of calling the built-in Spree::ItemTotal class directly.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

This is now merged in main and we should be using it from the patch.

Co-authored-by: benjamin wil <benjamin@super.gd>
Co-authored-by: Noah Silvera <noah@super.gd>
Co-authored-by: Senem Soy <senem@super.gd>
Co-authored-by: Kendra Riga <kendra@super.gd>
@benjaminwil benjaminwil requested a review from a team as a code owner July 29, 2025 17:04
@github-actions github-actions bot added the changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem label Jul 29, 2025
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@424f284). Learn more about missing BASE report.
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6312   +/-   ##
=======================================
  Coverage        ?   89.31%           
=======================================
  Files           ?      959           
  Lines           ?    20116           
  Branches        ?        0           
=======================================
  Hits            ?    17967           
  Misses          ?     2149           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good find!

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvdeyen tvdeyen added this to the 4.6 milestone Aug 5, 2025
@tvdeyen tvdeyen merged commit da70045 into solidusio:main Aug 5, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem

Projects

Development

Successfully merging this pull request may close these issues.

5 participants