Use new configuration setting for item total class#6312
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Aug 5, 2025
Merged
Use new configuration setting for item total class#6312tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen merged 1 commit intosolidusio:mainfrom
Conversation
This is now merged in main and we should be using it from the patch. Co-authored-by: benjamin wil <benjamin@super.gd> Co-authored-by: Noah Silvera <noah@super.gd> Co-authored-by: Senem Soy <senem@super.gd> Co-authored-by: Kendra Riga <kendra@super.gd>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6312 +/- ##
=======================================
Coverage ? 89.31%
=======================================
Files ? 959
Lines ? 20116
Branches ? 0
=======================================
Hits ? 17967
Misses ? 2149
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jarednorman
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In our work on the in-memory order updater (#5872), we created a new configuration point
item_total_class, but we did not use this configuration class in thesolidus_legacy_promotionsgem.This pull request simply starts using the configuration point instead of calling the built-in
Spree::ItemTotalclass directly.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: