Set required line item attributes earlier#6313
Merged
kennyadsl merged 2 commits intosolidusio:mainfrom Aug 5, 2025
Merged
Conversation
github-actions
bot
added
changelog:solidus_core
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6313 +/- ##
=======================================
Coverage ? 89.31%
=======================================
Files ? 959
Lines ? 20117
Branches ? 0
=======================================
Hits ? 17968
Misses ? 2149
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Instead of instantiating new records directly or using `mock_model`, we can use factories, which are more realistically set up objects. Co-Authored-By: benjamin wil <benjamin@super.gd> Co-Authored-By: Senem Soy <senem@super.gd> Co-Authored-By: Alistair Norman <alistair@super.gd>
This makes working with unpersisted line items easier because required attributes are set immediately. This change is in service of creating an in-memory order updater. Co-authored-by: Kendra Riga <kendra@super.gd> Co-authored-by: benjamin wil <benjamin@super.gd>
benjaminwil
force-pushed
the
set-required-line-item-attributes-earlier
branch
from
d77da61 to
dbc590f
Compare
github-actions
bot
added
the
changelog:solidus_promotions
adammathys
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes working with unpersisted line items easier because required attributes are set immediately. This change is in service of creating an in-memory order updater (#5872) but is not dependent on that work and can be merged as a separate small pull request.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: