Skip to content

Fix issue with splitting backordered units#6320

Merged
jarednorman merged 1 commit intomainfrom
fix-backordered-shipment-splitting
Sep 8, 2025
Merged

Fix issue with splitting backordered units#6320
jarednorman merged 1 commit intomainfrom
fix-backordered-shipment-splitting

Conversation

@adammathys
Copy link
Member

Summary

When splitting backordered inventory units, we were incorrectly sending all backordered units to the desired shipment, regardless of the quantity chosen.

Our original work on this changed from computing on_hand units first to the backordered ones. Unfortunately, we missed that we should only ever move as many as was requested, not all of the possible backordered ones.

Related to #6319

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

When splitting backordered inventory units, we were incorrectly sending
all backordered units to the desired shipment, regardless of the
quantity chosen.

Our original work on this changed from computing on_hand units first to
the backordered ones. Unfortunately, we missed that we should only ever
move as many as was requested, not all of the possible backordered ones.
@adammathys adammathys self-assigned this Sep 6, 2025
@adammathys adammathys requested a review from a team as a code owner September 6, 2025 01:30
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Sep 6, 2025
@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.35%. Comparing base (72f1b5c) to head (d368c57).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6320   +/-   ##
=======================================
  Coverage   89.35%   89.35%           
=======================================
  Files         961      961           
  Lines       20192    20194    +2     
=======================================
+ Hits        18043    18045    +2     
  Misses       2149     2149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen added this to the 4.6 milestone Sep 6, 2025
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great!

@jarednorman jarednorman merged commit 4671f9a into main Sep 8, 2025
39 checks passed
@jarednorman jarednorman deleted the fix-backordered-shipment-splitting branch September 8, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

Development

Successfully merging this pull request may close these issues.

3 participants