Fix issue with splitting backordered units#6320
Merged
jarednorman merged 1 commit intomainfrom Sep 8, 2025
Merged
Conversation
When splitting backordered inventory units, we were incorrectly sending all backordered units to the desired shipment, regardless of the quantity chosen. Our original work on this changed from computing on_hand units first to the backordered ones. Unfortunately, we missed that we should only ever move as many as was requested, not all of the possible backordered ones.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6320 +/- ##
=======================================
Coverage 89.35% 89.35%
=======================================
Files 961 961
Lines 20192 20194 +2
=======================================
+ Hits 18043 18045 +2
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When splitting backordered inventory units, we were incorrectly sending all backordered units to the desired shipment, regardless of the quantity chosen.
Our original work on this changed from computing on_hand units first to the backordered ones. Unfortunately, we missed that we should only ever move as many as was requested, not all of the possible backordered ones.
Related to #6319
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: