Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 31, 2025

Summary

We always use this method as an array anyway (ignoring the index value in all cases).

Let's remove the cognitive overhead to keep in mind that this is a sorted hash and make it more natural to use.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen added this to the 4.7 milestone Oct 31, 2025
@tvdeyen tvdeyen requested a review from a team as a code owner October 31, 2025 09:11
@github-actions github-actions bot added the changelog:solidus_promotions Changes to the solidus_promotions gem label Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.34%. Comparing base (2d1fcff) to head (be0c164).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6345   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files         961      961           
  Lines       20165    20165           
=======================================
  Hits        18016    18016           
  Misses       2149     2149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

We always use this method as an array anyway (ignoring
the index value in all cases).

Let's remove the cognitive overhead to keep in mind
that this is a sorted hash and make it more natural
to use.
@tvdeyen tvdeyen force-pushed the refactor-promotion-lanes branch from dbaae65 to be0c164 Compare October 31, 2025 09:19
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Always good to remove cognitive overhead from this code base.

@tvdeyen tvdeyen merged commit 60b88af into solidusio:main Nov 1, 2025
39 checks passed
@tvdeyen tvdeyen deleted the refactor-promotion-lanes branch November 1, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_promotions Changes to the solidus_promotions gem

Projects

Development

Successfully merging this pull request may close these issues.

3 participants