Allow optional passing of options to calculators#6346
Merged
mamhoff merged 1 commit intosolidusio:mainfrom Nov 1, 2025
Merged
Conversation
38a9e1d to
587348f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6346 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 961 961
Lines 20165 20165
=======================================
Hits 18016 18016
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
For the upcoming "strikethrough prices"/"promotion previews" feature, we need to allow passing options to calculator's `compute` methods. For strikethrough prices, we will need the current order and the desired quantity to be passed into the calculator, and this commit allows passing any desired options. Since calculators are polymorphic in all directions and can be used in all kinds of context, we don't specify which options are possible. This also does the groundwork for allowing the SolidusPromotions::Benefit to take options and pass them on to its calculator. Because these methods are used a lot in Solidus, adds YARD-style documentation to the modified methods.
587348f to
5a885dc
Compare
adammathys
approved these changes
Oct 31, 2025
tvdeyen
approved these changes
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For the upcoming "strikethrough prices"/"promotion previews" feature, we need to allow passing options to calculator's
computemethods.For strikethrough prices, we will need the current order and the desired quantity to be passed into the calculator, and this commit allows passing any desired options.
Since calculators are polymorphic in all directions and can be used in all kinds of context, we don't specify which options are possible.
This also does the groundwork for allowing the
SolidusPromotions::Benefit to take options and pass them on to its calculator.
Because these methods are used a lot in Solidus, adds YARD-style documentation to the modified methods.
Extracted from #6287
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: