Flat Rate calculator: Do not override #compute #6349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spree::Calculator#computedispatches tocompute_line_item,compute_shipmentorcompute_shipping_rate, and we want to keep that behavior. This also documents what kind of objects this calculator knows how to reasonably work with.Extracted from #6287
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: