Skip to content

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Oct 31, 2025

Summary

This also removes the FlexiRate calculator from the AdjustShipment Benefit, as Spree::Shipment does not respond to quantity and would therefore raise an error if used with this calculator.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

This also removes the FlexiRate calculator from the `AdjustShipment`
Benefit, as `Spree::Shipment` does not respond to `quantity` and would
therefore raise an error if used with this calculator.
@mamhoff mamhoff requested a review from a team as a code owner October 31, 2025 15:36
@github-actions github-actions bot added the changelog:solidus_promotions Changes to the solidus_promotions gem label Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.34%. Comparing base (2d1fcff) to head (bf27f18).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6351   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files         961      961           
  Lines       20165    20165           
=======================================
  Hits        18016    18016           
  Misses       2149     2149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen added this to the 4.7 milestone Nov 1, 2025
@mamhoff mamhoff merged commit cd7b9d3 into solidusio:main Nov 1, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_promotions Changes to the solidus_promotions gem

Projects

Development

Successfully merging this pull request may close these issues.

3 participants