Fix percent calculator dispatch #6352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds YARD docs to the probably most important calculator in the promotion system. Also stops it from overriding "compute" such that behavior from `Spree::Calculator` is inherited. Furthermore, improves the specs so that the polymorphism is tested.
We want `compute` to stay intact, and we want the calculator to document what kind of items it can discount. That's why we need to stop inheriting from the `Percent` calculator, because that will work with shipments and shipping rates, while anything to do with Distributed Amounts only works on line items.
github-actions
bot
added
the
changelog:solidus_promotions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6352 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 961 961
Lines 20165 20170 +5
=======================================
+ Hits 18016 18021 +5
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adammathys
approved these changes
Oct 31, 2025
mamhoff
changed the title
tvdeyen
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This stops the
Percentpromotion calculator from overridingSpree::Calculator#computeand make sure thePercentWithCapcalculator only responds to#compute_line_item.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: