Skip to content

Move shared examples for promo calculators to lib/ #6367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mamhoff merged 1 commit into from
Nov 7, 2025
+13 −12
Merged

Move shared examples for promo calculators to lib/ #6367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions promotions/lib/solidus_promotions/testing_support/shared_examples.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
require "solidus_promotions/testing_support/shared_examples/product_condition"
require "solidus_promotions/testing_support/shared_examples/taxon_condition"
require "solidus_promotions/testing_support/shared_examples/option_value_condition"
require "solidus_promotions/testing_support/shared_examples/promotion_calculator"
2 changes: 1 addition & 1 deletion ...ed_examples/calculator_shared_examples.rb → ...t/shared_examples/promotion_calculator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

RSpec.shared_examples_for "a calculator with a description" do
RSpec.shared_examples_for "a promotion calculator" do
describe ".description" do
subject { described_class.description }

Expand Down
3 changes: 2 additions & 1 deletion promotions/spec/models/solidus_promotions/calculators/distributed_amount_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

require "rails_helper"
require "shared_examples/calculator_shared_examples"

RSpec.describe SolidusPromotions::Calculators::DistributedAmount, type: :model do
let(:calculator) { described_class.new(preferred_amount: 15, preferred_currency: currency) }
Expand All @@ -13,6 +12,8 @@
let(:order) { create(:order_with_line_items, line_items_attributes: line_items_attributes) }
let(:currency) { "USD" }

it_behaves_like "a promotion calculator"

context "applied to an order" do
let(:line_items_attributes) { [{ price: 20 }, { price: 30 }, { price: 100 }] }

Expand Down
3 changes: 1 addition & 2 deletions promotions/spec/models/solidus_promotions/calculators/flat_rate_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

require "rails_helper"
require "shared_examples/calculator_shared_examples"

RSpec.describe SolidusPromotions::Calculators::FlatRate, type: :model do
subject { calculator.compute(discountable) }
Expand All @@ -14,7 +13,7 @@
)
end

it_behaves_like "a calculator with a description"
it_behaves_like "a promotion calculator"

context "compute_line_item" do
let(:discountable) { mock_model(Spree::LineItem, order: order) }
Expand Down
3 changes: 1 addition & 2 deletions promotions/spec/models/solidus_promotions/calculators/flexi_rate_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

require "rails_helper"
require "shared_examples/calculator_shared_examples"

RSpec.describe SolidusPromotions::Calculators::FlexiRate, type: :model do
let(:calculator) do
Expand All @@ -26,7 +25,7 @@
)
end

it_behaves_like "a calculator with a description"
it_behaves_like "a promotion calculator"

context "compute" do
subject { calculator.compute(line_item) }
Expand Down
3 changes: 1 addition & 2 deletions promotions/spec/models/solidus_promotions/calculators/percent_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

require "rails_helper"
require "shared_examples/calculator_shared_examples"

RSpec.describe SolidusPromotions::Calculators::Percent, type: :model do
context "compute" do
Expand Down Expand Up @@ -29,5 +28,5 @@
end
end

it_behaves_like "a calculator with a description"
it_behaves_like "a promotion calculator"
end
2 changes: 2 additions & 0 deletions promotions/spec/models/solidus_promotions/calculators/percent_with_cap_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
require "rails_helper"

RSpec.describe SolidusPromotions::Calculators::PercentWithCap, type: :model do
it_behaves_like "a promotion calculator"

context "applied to an order" do
let(:calculator) { described_class.new(preferred_percent: 15, preferred_max_amount: 50) }
let(:promotion) do
Expand Down
3 changes: 1 addition & 2 deletions promotions/spec/models/solidus_promotions/calculators/tiered_flat_rate_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# frozen_string_literal: true

require "rails_helper"
require "shared_examples/calculator_shared_examples"

RSpec.describe SolidusPromotions::Calculators::TieredFlatRate, type: :model do
let(:calculator) { described_class.new }

it_behaves_like "a calculator with a description"
it_behaves_like "a promotion calculator"

describe "#valid?" do
subject { calculator.valid? }
Expand Down
2 changes: 2 additions & 0 deletions ...ec/models/solidus_promotions/calculators/tiered_percent_on_eligible_item_quantity_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@

subject { promotion.benefits.first.calculator.compute(item) }

it_behaves_like "a promotion calculator"

# 2 Shirts at 50, 100 USD. 10 % == 10
it { is_expected.to eq(10) }

Expand Down
3 changes: 1 addition & 2 deletions promotions/spec/models/solidus_promotions/calculators/tiered_percent_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# frozen_string_literal: true

require "rails_helper"
require "shared_examples/calculator_shared_examples"

RSpec.describe SolidusPromotions::Calculators::TieredPercent, type: :model do
let(:calculator) { described_class.new }

it_behaves_like "a calculator with a description"
it_behaves_like "a promotion calculator"

describe "#valid?" do
subject { calculator.valid? }
Expand Down
Loading