DiscountOrder: Use #filter_map everywhere
#6369
Merged
+37
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is both more legible and clearer, and it should yield less iterations.
…onditions This is both a performance improvement and an improvement in functionality! Using `filter_map` here means we get all error messages even out of ineligible conditions when we do dry runs. Plus we do less work in loops.
This makes the whole class easier to read an a little bit faster.
github-actions
bot
added
the
changelog:solidus_promotions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6369 +/- ##
==========================================
- Coverage 89.44% 89.44% -0.01%
==========================================
Files 973 973
Lines 20303 20298 -5
==========================================
- Hits 18161 18156 -5
Misses 2142 2142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jarednorman
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reduces the number of loops the promotion system does by short-cutting loops with ineligible conditions. This was mostly done by looking at whether I'm using the
select {}.map {}.compactpattern anywhere and seeing whether I could replace it with#filter_mapwhich turns three loops into one.This also fixed the one long-standing pending spec that checks whether a dry run will check all possible conditions. Now it will.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: