Fix Rubocop offenses for November 2025#6372
Merged
mamhoff merged 2 commits intosolidusio:mainfrom Nov 17, 2025
Merged
Conversation
This cop makes a lot of sense for the part of the app that runs permanently, but both of these cases are instances where the code being aborted is run as a one-off from the command line.
These are fine.
github-actions
bot
added
changelog:solidus_core
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6372 +/- ##
=======================================
Coverage 89.44% 89.44%
=======================================
Files 973 973
Lines 20298 20298
=======================================
Hits 18156 18156
Misses 2142 2142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jarednorman
approved these changes
Nov 17, 2025
kennyadsl
approved these changes
Nov 17, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A new month, a new Rubocop version that has new cops.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: